Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip creating encoders when not needed #238

Merged
merged 2 commits into from
Feb 28, 2020
Merged

Skip creating encoders when not needed #238

merged 2 commits into from
Feb 28, 2020

Conversation

klauspost
Copy link
Owner

Only EncodeAll uses the channel of encoders, so only allocate it when needed there.

Fixes #235

Reported by @jpchen-lightstep

@klauspost
Skip creating encoders when not needed
7f65386 
Only EncodeAll uses the channel of encoders, so only allocate it when needed there.

Fixes #235

Reported by @jpchen-lightstep
@klauspost
Set default if encoder hasn't been initialized.
8898848
@klauspost klauspost merged commit 022415c into master Feb 28, 2020
@klauspost klauspost deleted the skip-encoder-init branch February 28, 2020 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zstd: Extra encoders and decoders allocated when working with stream APIs
1 participant
@klauspost